-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmirano/3782 proposed budget restructure #3914
Conversation
…dmirano/3776-apd-component-restructure
…omponent-restructure fixed merge conflict in Wrapper.js
merge conflicts will be solved once executive summary refactor is in (#3912) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one file needs to be switched
web/src/pages/apd/ApdReadOnly.js
Outdated
@@ -17,7 +17,7 @@ import ApdSummary from '../../containers/viewOnly/ApdSummary'; | |||
import PreviousActivities from './previous-activities/PreviousActivities'; | |||
import Activities from '../../containers/viewOnly/activities/All'; | |||
import ScheduleSummary from './schedule-summary/ScheduleSummaryReadOnly'; | |||
import ProposedBudget from '../../containers/viewOnly/ProposedBudget'; | |||
import ProposedBudget from './proposed-budget/ProposedBudget'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are using the wrong one here, should be ProposedBudgetReadOnly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh!!! keep making the same mistake. will make sure to double check this once I create the other PRs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just pushed up the fix
…sed-budget-restructure
Codecov Report
@@ Coverage Diff @@
## main #3914 +/- ##
=======================================
Coverage 83.53% 83.53%
=======================================
Files 313 313
Lines 6400 6400
Branches 1210 1210
=======================================
Hits 5346 5346
Misses 960 960
Partials 94 94
Continue to review full report at Codecov.
|
This deploy was cleaned up. |
Resolves #3782
Description-
proposed budget refactor
This pull request changes...
This pull request was tested in the follow ways…
Steps to manually verify this change...
This pull request is ready to review when...
This pull request can be merged when…